Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream! when the client adapter models response headers as lists #275

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

pepicrft
Copy link
Contributor

We are using :ex_aws_s3 package in a project with :req as a client adapter, and we were experiencing an error because the logic to obtain the content size from the response headers assumes that the header is a binary. However, :req uses a list of strings as a type.

This PR adjusts the code to handle both cases gracefully. Please, let me know if you'd like me to add an integration test where :req is used as an adapter.

@pepicrft
Copy link
Contributor Author

Is anyone available for a review here (maybe @bernardd?)

@bernardd
Copy link
Contributor

Thanks @pepicrft!

@bernardd bernardd merged commit 95f4eaf into ex-aws:main Oct 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants