Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with graphql-ruby 2.3.x #90

Closed
gstokkink opened this issue Mar 21, 2024 · 6 comments · Fixed by #91
Closed

Incompatibility with graphql-ruby 2.3.x #90

gstokkink opened this issue Mar 21, 2024 · 6 comments · Fixed by #91

Comments

@gstokkink
Copy link

.tracer(...) has been deprecated, .trace_with(...) should be used instead: rmosolgo/graphql-ruby#4878.

`Schema.tracer(BatchLoader::GraphQL)` is deprecated; use module-based `trace_with` instead. See: https://graphql-ruby.org/queries/tracing.html
  /Users/work/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/batch-loader-2.0.1/lib/batch_loader/graphql.rb:10:in `use'
@exAspArk
Copy link
Owner

@gstokkink thank you! Sorry, I don't have the bandwidth right now. Feel free to submit a PR, I'll happily review it :)

@gstokkink
Copy link
Author

@exAspArk will do 🙂 thanks for the excellent gem by the way

@janko janko mentioned this issue Mar 25, 2024
Merged
@janko
Copy link
Contributor

janko commented Mar 25, 2024

Opened a PR – #91 🙂

@gstokkink
Copy link
Author

gstokkink commented Mar 25, 2024 •
edited
Loading

@janko thanks, didn't have time yet

@exAspArk
Copy link
Owner

I just released @janko's fix in v2.0.3 🎉

@janko
Copy link
Contributor

janko commented Mar 25, 2024

Thanks for the quick release! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use .trace_with on graphql-ruby 2.3+ janko/batch-loader
3 participants
@exAspArk @janko @gstokkink