Use .trace_with
on graphql-ruby 2.3+
#91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql-ruby 2.3 switched to new module-based tracing, which requires passing a module to
.trace_with
. This module should then implement instance methods for events it wants to intercept. So basically, instead of a case statement, we now have method calls.Also, the naming convention for modules within graphql-ruby is "trace", while the legacy classes were called "tracer". So, I chose to name the module
Trace
as well.I could have called
BatchLoader::GraphQL.trace("execute_field", data)
to be more DRY, but I didn't want new API to call into legacy API, so I chose a bit of duplication.Closes #90