Allow others to trace execute_field GQL event
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new tracing API works in a way that modules get included into a `GraphQL::Tracing::Trace` class, which provides a no-op `#execute_field` implementation that just yields. If we don't call `super`, other tracing modules that override `#execute_field` as well, that got included before batch-loader, won't get executed, because `yield` will short-circuit the execution.
|
Super! 🎉 I just released this fix in v2.0.4. Thank you! |
|
Thanks, I appreciate the quick release ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #91.
The new tracing API works in a way that modules get included into a
GraphQL::Tracing::Traceclass, which provides a no-op#execute_fieldimplementation that just yields. If we don't callsuper, other tracing modules that override#execute_fieldas well, that got included before batch-loader, won't get executed, becauseyieldwill short-circuit the execution.