Fix wrap_with_warning call for new tracing module #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the new tracing module, we call wrap_with_warning on the class so we should not make this a private method
engwan
commented
Apr 24, 2024
| @@ -45,7 +45,6 @@ def self.wrap_with_warning(batch_loader) | |||
| warn "DEPRECATION WARNING: using BatchLoader.for in GraphQL is deprecated. Use BatchLoader::GraphQL.for instead or return BatchLoader::GraphQL.wrap from your resolver." | |||
| wrap(batch_loader) | |||
| end | |||
| private_class_method :wrap_with_warning | |||
There was a problem hiding this comment.
On line 8 of this file, we call BatchLoader::GraphQL.wrap_with_warning. So we cannot make this a private method.
|
@engwan Ah, sorry, I missed that, thanks for the fix 👍🏻 |
|
@engwan nice, thank you! 🙌 I just released the fix in version 2.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new tracing module, we call
wrap_with_warningon the class so we should not make this a private method.This prevents errors like: