Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esl-carousel]: missed tag declarations of elements for TSX #2330

Open
ala-n opened this issue Apr 10, 2024 · 1 comment · Fixed by #2713
Open

[esl-carousel]: missed tag declarations of elements for TSX #2330

ala-n opened this issue Apr 10, 2024 · 1 comment · Fixed by #2713
Assignees
@ala-n
Labels
released on @beta
Milestone
⚡ESL: 5.0.0 Major...

Comments

@ala-n
Copy link
Collaborator

ala-n commented Apr 10, 2024 •
edited
Loading

Missed tag declarations of elements for TSX, so we can not use carousel from strictly typed JSX

Originally posted by @dshovchko in #2185 (comment)

Target: main-beta
@ala-n ala-n added the blocked Blocked by relation label Apr 16, 2024
@ala-n ala-n added needs assignee and removed blocked Blocked by relation labels May 8, 2024
@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone May 8, 2024
@ala-n ala-n self-assigned this Oct 21, 2024
ala-n added a commit that referenced this issue Oct 21, 2024
@ala-n
fix(esl-carousel): esl-carousel tag is not declared to be used in TSX
70b1607 
Closes: #2330
@ala-n ala-n mentioned this issue Oct 21, 2024
Merged
@ala-n ala-n linked a pull request Oct 21, 2024 that will close this issue
fix(esl-carousel): esl-carousel tag is not declared to be used in TSX #2713
Merged
ala-n pushed a commit that referenced this issue Oct 21, 2024
@semantic-release-bot
chore(release): 5.0.0-beta.37
067fa8c 
## [5.0.0-beta.37](v5.0.0-beta.36...v5.0.0-beta.37) (2024-10-21)

### Bug Fixes

* **esl-carousel:** add missing TSX declaration for `esl-carousel-dots` ([7f30c71](7f30c71))
* **esl-carousel:** esl-carousel tag is not declared to be used in TSX ([70b1607](70b1607)), closes [#2330](#2330)
* **esl-drag-to-scroll:** fix issue with un-prevented click action after drag ([c98cfa4](c98cfa4))
* **esl-drag-to-scroll:** fix propagation of the click if drag detected ([0b4aee6](0b4aee6))
@ala-n
Copy link
Collaborator Author

ala-n commented Oct 21, 2024

🎉 This issue has been resolved in version 5.0.0-beta.37 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ala-n ala-n

Labels
released on @beta
Projects
None yet
Milestone
⚡ESL: 5.0.0 Major release
Development

Successfully merging a pull request may close this issue.

fix(esl-carousel): esl-carousel tag is not declared to be used in TSX exadel-inc/esl
1 participant
@ala-n