Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-carousel): multiple carousel touch behavior fixes #2552

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

ala-n
Copy link
Collaborator

@ala-n ala-n commented Jul 30, 2024

No description provided.

ala-n and others added 3 commits July 30, 2024 16:57
…during move action routines

Co-authored-by: Anna Barmina <abarmina@exadel.com>
- Renderer `onMove` method renamed to `move`
- Both `move` and `commit` methods expect optional base slide to make shift
- Replace `indexByOffset` common move method with actual purpose - `INDEX_MOVE_MULTIPLIER` getter

Co-authored-by: Anna Barmina <abarmina@exadel.com>
…t is used

Co-authored-by: Anna Barmina <abarmina@exadel.com>
@ala-n ala-n added bug Something isn't working needs review The PR is waiting for review labels Jul 30, 2024
@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone Jul 30, 2024
@ala-n ala-n requested review from a team July 30, 2024 16:51
@ala-n ala-n requested review from yadamskaya, abarmina and fshovchko and removed request for a team July 30, 2024 16:51
Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com>
@ala-n ala-n merged commit a35928e into main-beta Jul 30, 2024
7 checks passed
@ala-n ala-n deleted the feat/esl-carousel-move-reworked branch July 30, 2024 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@ala-n
Copy link
Collaborator Author

ala-n commented Jul 30, 2024

🎉 This issue has been resolved in version 5.0.0-beta.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs review The PR is waiting for review released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants