-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esl-carousel): multiple carousel touch behavior fixes #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during move action routines Co-authored-by: Anna Barmina <abarmina@exadel.com>
- Renderer `onMove` method renamed to `move` - Both `move` and `commit` methods expect optional base slide to make shift - Replace `indexByOffset` common move method with actual purpose - `INDEX_MOVE_MULTIPLIER` getter Co-authored-by: Anna Barmina <abarmina@exadel.com>
…t is used Co-authored-by: Anna Barmina <abarmina@exadel.com>
ala-n
added
bug
Something isn't working
needs review
The PR is waiting for review
labels
Jul 30, 2024
ala-n
requested review from
yadamskaya,
abarmina and
fshovchko
and removed request for
a team
July 30, 2024 16:51
NastaLeo
approved these changes
Jul 30, 2024
fshovchko
approved these changes
Jul 30, 2024
dshovchko
approved these changes
Jul 30, 2024
Co-authored-by: Anastasiya Lesun <72765981+NastaLeo@users.noreply.github.com>
abarmina
approved these changes
Jul 30, 2024
🎉 This issue has been resolved in version 5.0.0-beta.29 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.