feat(esl-carousel): rework default renderer animation approach (now uses js animation) #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses js animation)
ala-n
requested review from
yadamskaya,
fshovchko and
NastaLeo
and removed request for
a team
fshovchko
approved these changes
Jul 31, 2024
dshovchko
approved these changes
Aug 1, 2024
| await this.$area.animate({ | ||
| transform: [`translate3d(${this.vertical ? `0px, ${offset}px` : `${offset}px, 0px`}, 0px)`] | ||
| }, {duration: 250, easing: 'linear'}).finished; | ||
| this.$carousel.$$attr('animating', false); |
There was a problem hiding this comment.
Just cosmetic to define a method something like setAnimationState()
There was a problem hiding this comment.
But what will be the purpose? it is not public and is commonly used for other methods or inheritors. From the current update state animateTransformOffset and only animateTransformOffset should process animation and notify regarding the animation state. It is not designed for animated markers to be updated out of the context of animation
abarmina
approved these changes
Aug 1, 2024
fix(esl-carousel): direction related issues, cleanup internal nav API (rename dir to direction)
|
🎉 This issue has been resolved in version 5.0.0-beta.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.