Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Accuracy Issues #80

Merged
merged 11 commits into from
Jun 9, 2021
Merged

BUG: Accuracy Issues #80

merged 11 commits into from
Jun 9, 2021

Conversation

skailasa
Copy link
Collaborator

@skailasa skailasa commented Jun 9, 2021 •
edited
Loading

This addresses #77, which details a number of at the time unknown issues with the accuracy of PyExaFMM. I can report that there were 3 main issues, which are addressed in this PR.

  1. Calculation of the pseudoinverse of highly ill conditioned matrix
  2. Random BS bugs (casting contribution from W List to int rather than float, thus rounding it to 0)
  3. A catastrophic bug in the calculation of the V List for leaf nodes not discretised to maximum level, which was fixed here

@skailasa skailasa merged commit f6caf9c into master Jun 9, 2021
@skailasa skailasa mentioned this pull request Jun 9, 2021
Closed
@skailasa skailasa deleted the bug/accuracy branch June 25, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skailasa