Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run acceptance tests also for newer puppet versions #220

Merged
merged 4 commits into from
Jan 14, 2018

Conversation

tuxmea
Copy link
Contributor

@tuxmea tuxmea commented Jan 13, 2018

acceptance test install puppet into a container/vm

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.
@alvagante
Copy link
Member

alvagante commented Jan 13, 2018

1 Warning
⚠️ Please provide a summary in the Pull Request description
2 Messages
📖 Changes in tests but not in manifests. If the affect tests resulat, in theory this should not happen.
📖 There are changes on Hiera files. They will probably affect one or more nodes.

Generated by 🚫 Danger

@alvagante alvagante merged commit 99bcf45 into integration Jan 14, 2018
alvagante pushed a commit that referenced this pull request Jan 14, 2018
* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

Add full path to Jenkinsfile bundle

starting works on foss setup

Works on foss vagrant env + docs

Fixed wrong hiera files chnagesdetection in Dangerfile
@tuxmea tuxmea deleted the puppet5acceptance branch January 14, 2018 12:48
alvagante added a commit that referenced this pull request Jan 14, 2018
* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

Add full path to Jenkinsfile bundle

starting works on foss setup

Works on foss vagrant env + docs

Fixed wrong hiera files chnagesdetection in Dangerfile
alvagante pushed a commit that referenced this pull request Jan 14, 2018
* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions
alvagante added a commit that referenced this pull request Jan 14, 2018
* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

Add full path to Jenkinsfile bundle

starting works on foss setup

Works on foss vagrant env + docs

Fixed wrong hiera files chnagesdetection in Dangerfile
alvagante pushed a commit that referenced this pull request Jan 30, 2018
Foss environment works

Force bundle run before rspec tests in gitlab

Puppetfile cleanup

Syntax fix

Puppet-lint gems from rubygems

Foss vagrant env based on Ubuntu1604

Add full path to Jenkinsfile bundle

starting works on foss setup

run acceptance tests also for newer puppet versions (#220)

* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

run acceptance tests also for newer puppet versions (#220) (#221)

* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

Add full path to Jenkinsfile bundle

starting works on foss setup

Works on foss vagrant env + docs

Fixed wrong hiera files chnagesdetection in Dangerfile

Fix Typo

Temporarily gemove trouble Gemfile.local

Syntax fix for bin/puppet_job_run.sh

gitlab ci integration tests

Removed spec/acceptance/psick_spec.rb

Test puppetmaster role with beaker

Foss environment works

Added domain fact to acceptance test spec

Run puppet jobs in CI only for local domain

Saner message in Dangerfile

Add docker to ostest-ubuntu1604.lab.psick.io

Lints for Codacy

Testing pdk on travis #230

Tunong pdk tests in .travis.yml
alvagante added a commit that referenced this pull request Jan 31, 2018
* Add bundle execution in Jenkinsfile setup

* Add full path to Jenkinsfile bundle

* starting works on foss setup

* run acceptance tests also for newer puppet versions (#220)

* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

* run acceptance tests also for newer puppet versions (#220) (#221)

* run acceptance tests also for newer puppet versions

reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

Add full path to Jenkinsfile bundle

starting works on foss setup

Works on foss vagrant env + docs

Fixed wrong hiera files chnagesdetection in Dangerfile

* Create CODE_OF_CONDUCT.md

* Tests and vagrant works (Should fix #146)

* Create CODE_OF_CONDUCT.md

Foss environment works

Force bundle run before rspec tests in gitlab

Puppetfile cleanup

Syntax fix

Puppet-lint gems from rubygems

Foss vagrant env based on Ubuntu1604

Add full path to Jenkinsfile bundle

* starting works on foss setup

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

* run acceptance tests also for newer puppet versions

* reusing the PUPPET_GEM_VERSION environment variable which is also taken
for rspec-puppet.

* switch from PUPPET_GEM_VERSION to installed puppet version

* remove pry

* smarter handling of installing specific puppet versions

* Add full path to Jenkinsfile bundle

* starting works on foss setup

* Works on foss vagrant env + docs

* Fixed wrong hiera files chnagesdetection in Dangerfile

* Fix Typo

* Temporarily gemove trouble Gemfile.local

Syntax fix for bin/puppet_job_run.sh

gitlab ci integration tests

Removed spec/acceptance/psick_spec.rb

Test puppetmaster role with beaker

Foss environment works

Added domain fact to acceptance test spec

Run puppet jobs in CI only for local domain

Saner message in Dangerfile

Add docker to ostest-ubuntu1604.lab.psick.io

Lints for Codacy

Testing pdk on travis #230

Tunong pdk tests in .travis.yml

Deploy modules in travis

Travis fixes

try pdk on travis without error suppression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants