-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run acceptance tests also for newer puppet versions #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet.
Generated by 🚫 Danger |
alvagante
pushed a commit
that referenced
this pull request
Jan 14, 2018
* run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions Add full path to Jenkinsfile bundle starting works on foss setup Works on foss vagrant env + docs Fixed wrong hiera files chnagesdetection in Dangerfile
alvagante
added a commit
that referenced
this pull request
Jan 14, 2018
* run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions Add full path to Jenkinsfile bundle starting works on foss setup Works on foss vagrant env + docs Fixed wrong hiera files chnagesdetection in Dangerfile
alvagante
pushed a commit
that referenced
this pull request
Jan 14, 2018
* run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions
alvagante
added a commit
that referenced
this pull request
Jan 14, 2018
* run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions Add full path to Jenkinsfile bundle starting works on foss setup Works on foss vagrant env + docs Fixed wrong hiera files chnagesdetection in Dangerfile
alvagante
pushed a commit
that referenced
this pull request
Jan 30, 2018
Foss environment works Force bundle run before rspec tests in gitlab Puppetfile cleanup Syntax fix Puppet-lint gems from rubygems Foss vagrant env based on Ubuntu1604 Add full path to Jenkinsfile bundle starting works on foss setup run acceptance tests also for newer puppet versions (#220) * run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions run acceptance tests also for newer puppet versions (#220) (#221) * run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions Add full path to Jenkinsfile bundle starting works on foss setup Works on foss vagrant env + docs Fixed wrong hiera files chnagesdetection in Dangerfile Fix Typo Temporarily gemove trouble Gemfile.local Syntax fix for bin/puppet_job_run.sh gitlab ci integration tests Removed spec/acceptance/psick_spec.rb Test puppetmaster role with beaker Foss environment works Added domain fact to acceptance test spec Run puppet jobs in CI only for local domain Saner message in Dangerfile Add docker to ostest-ubuntu1604.lab.psick.io Lints for Codacy Testing pdk on travis #230 Tunong pdk tests in .travis.yml
alvagante
added a commit
that referenced
this pull request
Jan 31, 2018
* Add bundle execution in Jenkinsfile setup * Add full path to Jenkinsfile bundle * starting works on foss setup * run acceptance tests also for newer puppet versions (#220) * run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions * run acceptance tests also for newer puppet versions (#220) (#221) * run acceptance tests also for newer puppet versions reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions Add full path to Jenkinsfile bundle starting works on foss setup Works on foss vagrant env + docs Fixed wrong hiera files chnagesdetection in Dangerfile * Create CODE_OF_CONDUCT.md * Tests and vagrant works (Should fix #146) * Create CODE_OF_CONDUCT.md Foss environment works Force bundle run before rspec tests in gitlab Puppetfile cleanup Syntax fix Puppet-lint gems from rubygems Foss vagrant env based on Ubuntu1604 Add full path to Jenkinsfile bundle * starting works on foss setup * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions * run acceptance tests also for newer puppet versions * reusing the PUPPET_GEM_VERSION environment variable which is also taken for rspec-puppet. * switch from PUPPET_GEM_VERSION to installed puppet version * remove pry * smarter handling of installing specific puppet versions * Add full path to Jenkinsfile bundle * starting works on foss setup * Works on foss vagrant env + docs * Fixed wrong hiera files chnagesdetection in Dangerfile * Fix Typo * Temporarily gemove trouble Gemfile.local Syntax fix for bin/puppet_job_run.sh gitlab ci integration tests Removed spec/acceptance/psick_spec.rb Test puppetmaster role with beaker Foss environment works Added domain fact to acceptance test spec Run puppet jobs in CI only for local domain Saner message in Dangerfile Add docker to ostest-ubuntu1604.lab.psick.io Lints for Codacy Testing pdk on travis #230 Tunong pdk tests in .travis.yml Deploy modules in travis Travis fixes try pdk on travis without error suppression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acceptance test install puppet into a container/vm