This repository has been archived by the owner on Jun 11, 2019. It is now read-only.
mysql: fix test for future parser. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -423,7 +423,7 @@ | |||
| } | |||
|
|
|||
| # The whole mysql configuration directory can be recursively overriden | |||
| if $mysql::source_dir { | |||
| if $mysql::source_dir != '' { | |||
There was a problem hiding this comment.
I would change these conditionals to :
if $mysql::source_dir and $mysql::source_dir != '' {
so that nothing is done if the value is false (boolean)
|
I just pushed a commit to update the conditionals, thanks. |
alvagante
added a commit
that referenced
this pull request
Sep 29, 2015
mysql: fix test for future parser.
|
Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alessandro,
Fixes for future parser.
Not sure if we could (and if it would be preferable to) initialize source_dir and my_class at false or undef in params.pp (as proposed in #65 by @wooziethe), but as I saw equivalent things merged to example42/php I choose to modify the test.
Thanks!