Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFront Distribution for Example Data S3 Bucket #301

Closed
9 tasks done
ckunki opened this issue Jul 11, 2024 · 1 comment · Fixed by #310 or #311
Closed
9 tasks done

CloudFront Distribution for Example Data S3 Bucket #301

ckunki opened this issue Jul 11, 2024 · 1 comment · Fixed by #310 or #311
Assignees
Labels
feature Product feature

Comments

@ckunki
Copy link
Contributor

ckunki commented Jul 11, 2024

Adding an IBIS Notebook to the AI Lab requires additional resources on AWS as we expect the involved example data to be of significant volume.

Additionally, the data should be retrievable in a non-supervised way, i.e. cannot be guarded by a captcha, as this is the case for the existing S3 bucket containing the AI-Lab VM images.

The current ticket therefore requests to enhance the AI-Lab by

  • CF Template for S3 Bucket with a Cloudfront distribution for Example Data
  • CF Template for WAF without Captcha

AI-Lab should allow applying these templates independently of the existing templates for VM bucket and related WAF by offering separate commands or CLI options.

Tasks

  • Refactor existing code and tests to allow creating an additional cloudformation stack for example data PR #310
  • add test that template for vm bucket and its WAF is rendered identically to the old version.

Add support for the AI-Lab example data S3 bucket and WAF:

  • Duplicate and modify jinja templates vm_bucket_cloudformation.jinja.yaml and waf_cloudformation.jinja.yaml
  • Enhance ai-lab inject additional configuration parameters into jinja templates
  • Add CLI options
  • Add CLI tests
  • Update Developer Guide
  • Do we need to update or enhance tests for actual buckets and waf?
  • Do we need to support allowed_ip for example data WAF (VM bucket WAF only uses this for its captcha)?
@ckunki
Copy link
Contributor Author

ckunki commented Jul 23, 2024

Questions:

ckunki added a commit that referenced this issue Jul 25, 2024
* Related to #301: Refactored bucket handling 
* [CodeBuild]
ckunki added a commit that referenced this issue Jul 25, 2024
@ckunki ckunki reopened this Jul 26, 2024
ckunki added a commit that referenced this issue Aug 1, 2024
ckunki added a commit that referenced this issue Aug 8, 2024
* #301: Added CloudFront distribution for example data S3 bucket
* Replaced vm_dss_bucket.py by generic class in s3/buckets.py
* Added cli option --purpose to commands setup_s3_bucket and setup_waf
* Forward the region to Boto client even if user does not provide CLI option  --aws-profile
* [CodeBuild]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
1 participant