Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#150: Used multipart upload for VM images #154

Merged
merged 16 commits into from
Jan 31, 2024
Merged

#150: Used multipart upload for VM images #154

merged 16 commits into from
Jan 31, 2024

Conversation

ckunki
Copy link
Contributor

@ckunki ckunki commented Jan 31, 2024

closes #150

@ckunki
Moved test to directory test/codebuild
230e153 
used identical environment variable as for other codebuild tests
and renamed file to include test execution with codebuild tests
@ckunki ckunki requested a review from tkilias January 31, 2024 14:23
@ckunki ckunki changed the title #150 Enhanced AwsAccess and added integration test #150 Used multipart upload for VM images Jan 31, 2024
tkilias
tkilias previously approved these changes Jan 31, 2024
View reviewed changes
@ckunki
Changed implementation of transfer_to_s3
b18e77a 
Download to temp file in local filesystem before using upload.
Renamed method to upload_large_s3_object()
@ckunki
Updated method rename_image_in_s3()
0bdefc4
tkilias
tkilias requested changes Jan 31, 2024
View reviewed changes
exasol/ds/sandbox/lib/aws_access/aws_access.py
cloud_client.upload_file(source, bucket, dest, Config=config, Callback=callback)

callback = progress.report
tmpfile = NamedTemporaryFile(delete=False).name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with NamedTemporaryFile(delete=False) as tmpfile:

@tkilias tkilias changed the title #150 Used multipart upload for VM images #150: Used multipart upload for VM images Jan 31, 2024
@tkilias tkilias merged commit aaa08fb into main Jan 31, 2024
6 checks passed
@tkilias tkilias deleted the feature/#150-Use_multipart_upload_for_VM_images_on_AWS branch January 31, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use multipart upload for VM images on AWS
2 participants
@ckunki @tkilias