Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #2

Merged
merged 32 commits into from
Oct 11, 2023
Merged

Fix build #2

merged 32 commits into from
Oct 11, 2023

Conversation

ckunki
Copy link
Contributor

@ckunki ckunki commented Sep 27, 2023

closes #1

@ckunki ckunki temporarily deployed to AWS September 27, 2023 15:06 — with GitHub Actions Inactive
@ahsimb ahsimb self-requested a review September 28, 2023 10:19
Nicoretti
Nicoretti reviewed Sep 28, 2023
View reviewed changes
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/test/conftest.py Outdated
Comment on lines 4 to 5
here = os.path.abspath(".")
sys.path.insert(0, here)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your intention here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was to run tests with pytest.

secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
kaklakariada
kaklakariada requested changes Sep 29, 2023
View reviewed changes
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/secret_store.py Outdated Show resolved Hide resolved
secret-store/test/test_secret_store.py Outdated Show resolved Hide resolved
secret-store/test/test_secret_store.py Outdated Show resolved Hide resolved
ckunki and others added 2 commits October 6, 2023 12:34
@ckunki
fixed review finding
fbf4f43
@ckunki @kaklakariada @Nicoretti
Apply suggestions from code review
678fe82 
Co-authored-by: Christoph Pirkl <christoph.pirkl@exasol.com>
Co-authored-by: Nicola Coretti <nico.coretti@gmail.com>
@ckunki ckunki temporarily deployed to AWS October 6, 2023 10:45 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 6, 2023 13:35 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 6, 2023 14:39 — with GitHub Actions Inactive
kaklakariada
kaklakariada previously approved these changes Oct 9, 2023
View reviewed changes
@ckunki ckunki temporarily deployed to AWS October 9, 2023 07:46 — with GitHub Actions Inactive
Nicoretti
Nicoretti reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@Nicoretti Nicoretti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ckunki ckunki temporarily deployed to AWS October 9, 2023 07:59 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TEST October 9, 2023 11:57 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 07:47 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 07:55 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 08:05 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 08:11 — with GitHub Actions Inactive
kaklakariada
kaklakariada previously approved these changes Oct 10, 2023
View reviewed changes
@ckunki ckunki temporarily deployed to AWS October 10, 2023 08:32 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 09:02 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 09:33 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 09:39 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS October 10, 2023 09:56 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 10, 2023 11:38 — with GitHub Actions Inactive
kaklakariada
kaklakariada previously approved these changes Oct 10, 2023
View reviewed changes
@ckunki
Removed secret store as this will be maintained in repo notebook-conn…
4a07d7f 
…ector

... and imported as dependency from pypi later on
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 11, 2023 08:35 — with GitHub Actions Inactive
@ckunki ckunki changed the title initial implementation of secret store Fix build Oct 11, 2023
@ckunki ckunki merged commit dcf9145 into main Oct 11, 2023
3 checks passed
@ckunki ckunki deleted the feature/1-Implement-Secret-Store branch October 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti approved these changes

@kaklakariada kaklakariada kaklakariada approved these changes

@ahsimb ahsimb Awaiting requested review from ahsimb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CI Build (1d)
3 participants
@ckunki @Nicoretti @kaklakariada