Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#333: Added project short tag in notebook tests #334

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/notebook_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@ jobs:
NBTEST_AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
NBTEST_AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY_SECRET }}
NBTEST_AWS_DEFAULT_REGION: ${{ secrets.AWS_REGION }}
PROJECT_SHORT_TAG: XAIL-NB
4 changes: 4 additions & 0 deletions doc/changes/changes_3.2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@
Code name:

## Summary

## Refactorings

* #333: Added project short tag in notebook tests
2 changes: 1 addition & 1 deletion doc/developer_guide/updating_packages.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ If the update is very new and not yet displayed on packages.ubuntu.com you can u

```shell
apt-get update
apt-search <package>
apt search <package>
```

Maybe installing the command [chdist](https://manpages.ubuntu.com/manpages/xenial/en/man1/chdist.1.html) could also be helpful, as it allows searching for packages and updates in other versions and distributions of ubuntu than the one installed on your local system.
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
apt_dependencies:
- apt-transport-https=2.4.5
- gpg-agent=2.2.27-3ubuntu2.1
- ca-certificates=20230311ubuntu0.22.04.1
- ca-certificates=20240203~22.04.1
- software-properties-common=0.99.22.9
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ def test_notebook(notebook_test_container_with_log, notebook_test_file, notebook
environ = os.environ.copy()
environ["NBTEST_ACTIVE"] = "TRUE"
nbtest_environ = {key: value for key, value in environ.items() if (
key.startswith("NBTEST_") or key.startswith("SAAS_"))}
key.startswith("NBTEST_")
or key.startswith("SAAS_")
or key == "PROJECT_SHORT_TAG")}
exec_command(
command_run_test,
container,
Expand Down
Loading