Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#150: Added extracted parquet-io-java library #159

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

morazow
Copy link
Contributor

@morazow morazow commented Jul 15, 2021

Fixes #150

Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion

import org.apache.parquet.schema.MessageType
import org.apache.parquet.schema.Type.Repetition

final case class ParquetValueConverter(schema: MessageType) extends ValueConverter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a small doc explaining which kind of conversion it is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@morazow morazow merged commit 2d6d292 into main Jul 15, 2021
@morazow morazow deleted the refactoring/#150-use-parquet-io-library branch July 15, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use extracted Parquet library
2 participants