Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver manager uses wrong JAR name in manifest #219

Closed
kaklakariada opened this issue Jan 24, 2023 · 0 comments · Fixed by #222
Closed

Driver manager uses wrong JAR name in manifest #219

kaklakariada opened this issue Jan 24, 2023 · 0 comments · Fixed by #222
Assignees
@kaklakariada
Labels
bug Unwanted / harmful behavior

Comments

@kaklakariada
Copy link
Collaborator

When installing a JDBC driver via the driver manager it uses the wrong filename for the driver jar in the manifest.
In method JdbcDriver.getManifest() the JAR name is hard coded to JAR=driver.jar. Instead it should use the actual name of the file.
@kaklakariada kaklakariada added the bug Unwanted / harmful behavior label Jan 24, 2023
@kaklakariada kaklakariada mentioned this issue Jan 24, 2023
Merged
@kaklakariada kaklakariada self-assigned this Jan 26, 2023
kaklakariada added a commit that referenced this issue Jan 26, 2023
@kaklakariada
#219: Fix driver name in manifest
96d7330
@kaklakariada kaklakariada mentioned this issue Jan 26, 2023
Merged
kaklakariada added a commit that referenced this issue Jan 26, 2023
@kaklakariada
Merge branch 'kaklakariada/issue220' into #219-fix-driver-manager-jar…
d65f6d7 
…-name
kaklakariada added a commit that referenced this issue Jan 27, 2023
@kaklakariada
Merge branch 'main' into #219-fix-driver-manager-jar-name
4bce400
kaklakariada added a commit that referenced this issue Jan 27, 2023
@kaklakariada
#219: Fix unit test
a171553
kaklakariada added a commit that referenced this issue Jan 30, 2023
@kaklakariada @ckunki
#219 Fix driver manager jar name (#222)
1f2638b 
Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaklakariada kaklakariada

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#219 Fix driver manager jar name exasol/exasol-testcontainers
1 participant
@kaklakariada