#220 SLC UX Gen 2

[ckunki]

Closes #220

[ckunki]

• Add prefix and rename method
• verify semantics of docker_tag_prefix

Proposal

flavors = (ScriptLanguageContainer.flavor_path,)
clean_flavor_images(
    output_directory=str(self.workspace.output_path),
    flavor=flavors
)

[ckunki]

Done

[tomuben]

Maybe you will need to use

with current_directory(self.session.checkout_dir):

[ckunki]

I think we don't need with current_directory(self.session.checkout_dir):

• Workspace.output_path is defined self.root_dir / "output"
• ScriptLanguageContainer.__init__() initializes Workspace with Workspace(Path.cwd())
• Path.cwd() returns an absolute path

[tomuben]

Some of the exaslct api calls which use the argument flavor_path unfortunately only wors if the flavor path is relative to the cloned repository. Maybe clean_flavor_images works with any directory, not sure.

[ckunki]

Please correct me if I'm wrong: flavor_path is still relative to the cloned directory:

@property
def flavor_path(self) -> Path:
    return self.checkout_dir / constants.FLAVORS_PATH_IN_SLC_REPO / self.flavor

[tomuben]

Hm, if we use the values from slc for testing, we don't actually test if they have the expected values. I mean, there could be something wrong with slc.language_alias. Wouldn't it be better if test for the real name? Or do we have already an unit test for property language_alias?

[ckunki]

The implementation of property is rather trivial:

    @property
    def language_alias(self) -> str:
        return f"custom_slc_{self.name}"

The actual value of the language alias IMHO is not important.
But, as talking about it, it comes to my mind that it should be unique, for example.
The correctness of the language alias is verified by integration test test_udf_with_custom_packages()

Please tell me, if you still request adding a unit test.

In this case, I will add verifying the uniqueness depending on the SLC's name.

[ckunki]

I will add a unit test.

[ckunki]

I added a unit test verifying the expected language_alias.

[tomuben]

Suggested change

	with slc_factory.context(sample_slc_name, flavor) as slc:
	testee = slc
	with slc_factory.context(sample_slc_name, flavor) as testee:

[ckunki]

In this case you need to add pass

[ckunki]

See last push.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud