Skip to content

#236: Improved flavor check and added access to slc-rel Github data #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tomuben merged 10 commits into from
Aug 15, 2025
Merged

#236: Improved flavor check and added access to slc-rel Github data #237

tomuben merged 10 commits into from
Aug 15, 2025

Conversation

@tomuben
Copy link
Contributor

@tomuben tomuben commented Aug 14, 2025

fixes #236

@tomuben tomuben force-pushed the refactoring/236_check_if_flavor_exists branch from dc58048 to ae5ae4c Compare August 14, 2025 16:15
tomuben
tomuben commented Aug 14, 2025
View reviewed changes
exasol/nb_connector/slc/script_language_container.py Outdated
Comment on lines 86 to 90
if not self.flavor_path.is_dir():
raise SlcError(
f"Given flavor {self.flavor} not found in version {constants.SLC_RELEASE_TAG} of "
"Script-Languages-Release. "
"Check out available flavors at https://github.com/exasol/script-languages-release/releases/tag/{constants.SLC_RELEASE_TAG}.")
Copy link
Contributor Author

@tomuben tomuben Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkilias , @sgn4sangar I'am just thinking: Should we simplify the list of available flavrs in the slc release? Currently the user can find this list by clicking Package Version Comparison between Release 9.7.0 and 9.6.0. However, there the template and standard flavors are mixed....

@tomuben tomuben temporarily deployed to manual-approval August 14, 2025 16:22 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 14, 2025 16:28 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 14, 2025 17:03 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 14, 2025 17:06 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 14, 2025 17:22 — with GitHub Actions Inactive
@tomuben tomuben changed the title #236: Added check to validate if flavor exists in cloned slc-rel repository #236: Improved flavor check and renamed class ScriptLanguageContainer Aug 14, 2025
@tomuben tomuben temporarily deployed to text-ai-prerelease August 14, 2025 17:30 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 14, 2025 17:45 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 14, 2025 17:50 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to manual-approval August 14, 2025 18:19 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 14, 2025 18:26 — with GitHub Actions Inactive
@tomuben tomuben changed the title #236: Improved flavor check and renamed class ScriptLanguageContainer #236: Improved flavor check and added link to slc-rel Github URL Aug 15, 2025
@tomuben tomuben changed the title #236: Improved flavor check and added link to slc-rel Github URL #236: Improved flavor check and added access to slc-rel Github Aug 15, 2025
@tomuben tomuben changed the title #236: Improved flavor check and added access to slc-rel Github #236: Improved flavor check and added access to slc-rel Github data Aug 15, 2025
@tomuben tomuben temporarily deployed to manual-approval August 15, 2025 09:56 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 15, 2025 09:58 — with GitHub Actions Inactive
ckunki
ckunki previously approved these changes Aug 15, 2025
View reviewed changes
@tomuben tomuben temporarily deployed to manual-approval August 15, 2025 10:39 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to text-ai-prerelease August 15, 2025 10:45 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tomuben tomuben merged commit e6bc11b into main Aug 15, 2025
27 checks passed
@tomuben tomuben deleted the refactoring/236_check_if_flavor_exists branch August 15, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckunki ckunki ckunki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improved flavor check and added access to slc-rel Github data

3 participants

@tomuben @ckunki