Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate validation by verifying existence of file exasol-manifest.json #48

Open
Tracked by #42
ckunki opened this issue Aug 13, 2024 · 0 comments · May be fixed by #64
Open
Tracked by #42

Activate validation by verifying existence of file exasol-manifest.json #48

ckunki opened this issue Aug 13, 2024 · 0 comments · May be fixed by #64
Assignees
@tomuben
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Aug 13, 2024 •
edited
Loading

Ticket #42 requested to enhance the SLC Deployer, to optionally wait until SLC is deployed to all nodes in the database cluster. This is implemented by verifying the existence of file exasol-manifest.json, which was added to all SLCS in the scope of ticket exasol/script-languages-container-tool#221.

It turned out that the integration tests of PEC failed, caused by using an SLC release not yet containing a manifest.

The developers decided to temporarily use the file /exaudf/exaudfclient_py3 as a workaround. This doesn't make PEC worse than before but will not provide enhanced validation.

The current ticket requests to replace the filename, again, as soon as the next release of script-languages-release is available, using an update version of SLCT to provide the file exasol-manifest.json.

Another option would be to

  • wait for PR Feature/45 slc build #47 to be merged
  • create a new release 0.21.0 for SLCT
  • update dependencies of PEC
  • build a custom SLC incl. manifest file
  • use this SLC in the integration test of the ExtractValidator

Building the SLC is probably already implemented in a pytest fixture in the scope of ticket #45.
@ckunki ckunki added the refactoring Code improvement without behavior change label Aug 13, 2024
This was referenced Aug 13, 2024
Merged
Closed
ckunki added a commit that referenced this issue Aug 14, 2024
@ckunki @tkilias
#42 2 integrate extract validator into language container deployer (#46)
c6c27ea 
* Integrated ExtractValidator into LanguageContainerDeployer
* Added file language_container_validator.py to provide backwards compatibility
* Fix until manifest is deployed with standard SLCs see #48 
* Fixed SQL syntax error
* Fixed integration test
* Fixed indention for UDF python script

Co-authored-by: Torsten Kilias <tkilias@users.noreply.github.com>
@tomuben tomuben self-assigned this Sep 20, 2024
tomuben added a commit that referenced this issue Sep 20, 2024
@tomuben
#48: Activated validation by verifying existence of file exasol-manif…
560402a 
…est.json
@tomuben tomuben linked a pull request Sep 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomuben tomuben

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
2 participants
@tomuben @ckunki