#103: exa.ReadData not working correctly under Windows #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Oct 12, 2021
RCA: During the refactoring (#63), the magic number = 1 for closing the socket for sending was replaced with SD_RECEIVE, but it should have been replaced with SD_SEND. The consequence was that the socket might have been closed before the ok answered was sent to the database. Fix: Replace SD_RECEIVE with SD_SEND
tomuben
force-pushed
the
bug/#103_exa_readdata_not_working_correctly_under_windows
branch
from
95dd2c1 to
35e2b54
Compare
tkilias
approved these changes
Oct 12, 2021
tomuben
deleted the
bug/#103_exa_readdata_not_working_correctly_under_windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA:
During the refactoring (#63),
the magic number = 1 for closing the socket for sending was
replaced with SD_RECEIVE, but it should have been replaced with SD_SEND.
The consequence was that the socket might have been closed
before the ok answered was sent to the database.
Fix:
Replace SD_RECEIVE with SD_SEND