#138: Add extension #139
#138: Add extension #139
Conversation
Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
…-level-security-lua into kaklakariada/issue138
There was a problem hiding this comment.
You might want to rewrite this at some point in the future in a less error-prone language.
There was a problem hiding this comment.
Options Typescript, Java or a Python script without dependencies (Python is usually somehow available and without dependencies, you are good to go.
There was a problem hiding this comment.
Good point. Next time I touch this file I will think about refactoring this.
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "row-level-security-extension", | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
Yes, that's fine because we will never publish this to NPM. Duplicating the version number here is just error prone and easy to forget.
| )`; | ||
|
|
||
| export function buildCreateScriptCommand(qualifiedScriptName: string, luaScriptContent: string) { | ||
| return `CREATE OR REPLACE LUA ADAPTER SCRIPT ${qualifiedScriptName} AS |
There was a problem hiding this comment.
oh, you are constructing the script here, hm, interesting we are doing this already in python. Ok, also a thing, I need to keep in mind.
|
|
||
| export function getInstalledExtension(): any { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | ||
| return (global as any).installedExtension |
There was a problem hiding this comment.
This is the "global" JS object. We use it to register an extension to make it available to the Extension Manager's JS runtime, see Go function loadExtension().
| @@ -166,6 +165,59 @@ | |||
| </arguments> | |||
| </configuration> | |||
| </execution> | |||
| <!-- Build extension --> | |||
| <execution> | |||
There was a problem hiding this comment.
Interesting, so you actually already call npm from maven, so probably could also call a typescript script which inlines the script
There was a problem hiding this comment.
Actually we call the shell script during npm run build (see package.json) ;)
Closes #138