Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Python < 3.8 #135

Closed
MarleneKress79789 opened this issue May 9, 2022 · 1 comment · Fixed by #145
Closed

Remove support for Python < 3.8 #135

MarleneKress79789 opened this issue May 9, 2022 · 1 comment · Fixed by #145
Assignees
@Nicoretti
Labels
refactoring Code improvement without behavior change

Comments

@MarleneKress79789
Copy link

This project supports python version >= 3.7. We want to remove older python versions.

  • Remove support for python version < 3.8
@MarleneKress79789 MarleneKress79789 added the refactoring Code improvement without behavior change label May 9, 2022
@Nicoretti
Copy link
Member

Nicoretti commented Jun 1, 2022 •
edited
Loading

TODO's to keep in mind for the migration

  • Change version provider of package version to installation metadata (see also)
    • Remove version file
    • Remove commit hook
    • Remove verifier step
  • Add a note to the release notes that we dropped 3.7 knowingly previous to EOL, if that should be a issue for somebody they should drop us a mail or file an issue.
  • Continue versioning with 3.X.Y so the 2.X.Y series can be used for backports if needed.

@Nicoretti Nicoretti mentioned this issue Jun 1, 2022
Merged
Nicoretti added a commit that referenced this issue Jun 1, 2022
@Nicoretti
Replace version information mechansim
4ea0d5e 
For now the version and iformation will be updated using a git hook and nox target.
When the project is upgraded to 3.8 we should replace this mechanism by
the use of importlib.metadata.

see also:
* #145 (comment)
* python-poetry/poetry#2366 (comment)
* #135 (comment)
@Nicoretti Nicoretti mentioned this issue Jul 7, 2022
Closed
1 task
@Nicoretti Nicoretti self-assigned this Jul 7, 2022
Nicoretti added a commit that referenced this issue Jul 7, 2022
@Nicoretti
Update changelog
037f906 
Fixes #135
@Nicoretti Nicoretti linked a pull request Jul 7, 2022 that will close this issue
#128 migrate project to pyrpoject toml based package setup #145
Merged
Nicoretti added a commit that referenced this issue Jul 14, 2022
@Nicoretti
Migrate project to pyproject.toml based package setup
ccb6983 
Fixes #128
Fixes #135 

* Add pyproject.toml
* Add poetry lock file
* Add dependencies to pyproject.toml
* Add dependabot updater to repository
* Add pyupgrade commit hook to workspace
* Remove deprecated and unused configuration entries
* Add extension points required for sqlalchemy plugin(s)
* Add version sync support for project.toml based version
* Add version check to ci/verifier action
* Update CI workflow to use poetry
* Update base python version to 3.8
* Update changelog
* Remove condaforge reference in README
   - Conda forge won't be maintained anymore.
* Deleted deprecated and unused files
* Use python built in mock library
* Bump version to 3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicoretti Nicoretti

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#128 migrate project to pyrpoject toml based package setup exasol/sqlalchemy-exasol
2 participants
@Nicoretti @MarleneKress79789