#74: Fix DATEADD tests #75
Conversation
javascript-test/package-lock.json
Outdated
There was a problem hiding this comment.
Could me mark this file as "generated"?
There was a problem hiding this comment.
It is already marked as generated:
javascript-test/package-lock.json linguist-generated=true
There was a problem hiding this comment.
Strange. Still GitHub displays only "Load diff" and not "...generated".
Could it be that file .gitattributes requires a trailing newline?
| @@ -3,12 +3,10 @@ set -euo pipefail | |||
|
|
|||
| project_dir="$( cd "$(dirname "$0")/.." >/dev/null 2>&1 ; pwd -P )" | |||
| readonly project_dir | |||
There was a problem hiding this comment.
Is there a specific reason for the other variables to be 1-liners while project_dir is defined and made read-only in separate lines?
There was a problem hiding this comment.
I remember that the shellcheck tool complains if you do this in one line 🤷
There was a problem hiding this comment.
Yes, I think so, too, but the other vars seem to be OK. Maybe simpler expressions?
| @@ -3,12 +3,10 @@ set -euo pipefail | |||
|
|
|||
| project_dir="$( cd "$(dirname "$0")/.." >/dev/null 2>&1 ; pwd -P )" | |||
| readonly project_dir | |||
There was a problem hiding this comment.
Yes, I think so, too, but the other vars seem to be OK. Maybe simpler expressions?
javascript-test/package-lock.json
Outdated
There was a problem hiding this comment.
Strange. Still GitHub displays only "Load diff" and not "...generated".
Could it be that file .gitattributes requires a trailing newline?
Closes #74