Skip to content

Enhance interface LocalServiceExposer and simplify usage #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckunki opened this issue Feb 6, 2023 · 0 comments · Fixed by #54
Closed

Enhance interface LocalServiceExposer and simplify usage #53

ckunki opened this issue Feb 6, 2023 · 0 comments · Fixed by #54
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Feb 6, 2023

Add convenience method to interface LocalServiceExposer

  public static LocalServiceExposer withoutPortMapping(final String host) {
    return port ->  new InetSocketAddress(host, port);
  }

Method forRemoteHost() can then be used in the following classes in project udf-debugging-java:

  • TestSetup
  • Constructors of UdfTestSetup

Change constructor of UdfTestSetup

Furthermore the constructor of UdfTestSetup can be simplified into

public UdfTestSetup(final ExasolTestSetup testSetup, final Connection exasolConnection) {
    return new UdfTestSetup(testSetup::makeLocalTcpServiceAccessibleFromDatabase,
        testSetup.getDefaultBucket(), exasolConnection);
}
@ckunki ckunki added the refactoring Code improvement without behavior change label Feb 6, 2023
ckunki added a commit that referenced this issue Feb 7, 2023
@ckunki ckunki mentioned this issue Feb 7, 2023
@ckunki ckunki closed this as completed in #54 Feb 7, 2023
ckunki added a commit that referenced this issue Feb 7, 2023
* Implemented #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant