Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Animation current time methods #2874

Merged
merged 4 commits into from
Jan 9, 2024
Merged

feat: Animation current time methods #2874

merged 4 commits into from
Jan 9, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jan 9, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR adds new property and methods overloads to ex.Animation

  • ex.Animation.currentFrameTimeLeft will return the current time in milliseconds left in the current
  • ex.Animation.goToFrame(frameNumber: number, duration?: number) now accepts an optional duration for the target frame

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jan 9, 2024
@eonarheim eonarheim merged commit dca55c2 into main Jan 9, 2024
4 of 5 checks passed
@eonarheim eonarheim deleted the fix/animation-syncing branch January 9, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant