Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Polygon winding correct after negative transforms #3063

Merged
merged 1 commit into from
May 16, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented May 16, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Fixes an issue brought in the discord where negative transforms would cause polygon winding to change causing collision logic to no longer function properly

chickens.mp4

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label May 16, 2024
Copy link

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6d0ddd6
Status: ✅  Deploy successful!
Preview URL: https://56c104ca.excaliburjs.pages.dev
Branch Preview URL: https://fix-transform-winding-change.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 5be85b7 into main May 16, 2024
8 of 9 checks passed
@eonarheim eonarheim deleted the fix/transform-winding-change branch May 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant