Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: z-indexes are relative to their parent #3070

Merged
merged 1 commit into from
May 20, 2024
Merged

Feat: z-indexes are relative to their parent #3070

merged 1 commit into from
May 20, 2024

Conversation

mattjennings
Copy link
Contributor

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Changes:

  • Z-indexes are now relative to the parent's Z-index. You can get the global Z-index with the globalZ property on the Actor or TransformComponent.

@github-actions github-actions bot added the enhancement Label applied to enhancements or improvements to existing features label May 20, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0572c20
Status: ✅  Deploy successful!
Preview URL: https://62154995.excaliburjs.pages.dev
Branch Preview URL: https://feat-child-local-z.excaliburjs.pages.dev

View logs

@mattjennings mattjennings marked this pull request as ready for review May 20, 2024 20:37
eonarheim
eonarheim approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@eonarheim eonarheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattjennings Looks great, thanks again!

@eonarheim eonarheim merged commit 47cbb18 into main May 20, 2024
8 of 9 checks passed
@eonarheim eonarheim deleted the feat/child-local-z branch May 20, 2024 21:30
@eonarheim eonarheim mentioned this pull request Jun 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eonarheim eonarheim eonarheim approved these changes

Assignees
No one assigned
Labels
enhancement Label applied to enhancements or improvements to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjennings @eonarheim