Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed invalid null as value from Random.shuffle() #3095

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Autsider666
Copy link
Contributor

Setting null on a variable of type T isn't valid in the eyes of TS

Setting `null` on a variable of type `T` isn't valid in the eyes of TS
@Autsider666
Copy link
Contributor Author

Ran into this one because I'm copy-pasting some often used classes into my own codebase (while referencing EX ofc) so I can experiment with workers

@eonarheim
Copy link
Member

@Autsider666 Thanks again!

@eonarheim eonarheim merged commit 3b6bd7d into excaliburjs:main Jun 11, 2024
4 checks passed
@Autsider666 Autsider666 deleted the patch-2 branch July 19, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants