Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3126] Fix keyboard events in scene scope #3127

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jul 16, 2024

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #3126

Fixes an issue where key events (and other event types) get stuck in the previous scene InputHost and cause issues when switching back. This state will never be useful and has lost relevancy after the scene has switched.

Changes:

  • Adds a InputHost.clear() to clear previous scene event state
  • Director clears the previous scene input host

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jul 16, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5f9dd4
Status: ✅  Deploy successful!
Preview URL: https://70aeb026.excaliburjs.pages.dev
Branch Preview URL: https://fix-scene-input-events-on-sc.excaliburjs.pages.dev

View logs

@eonarheim eonarheim merged commit 10c75ce into main Jul 17, 2024
8 checks passed
@eonarheim eonarheim deleted the fix/scene-input-events-on-scene-switch branch July 17, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scenes consistently swallowing keyboard events after switching back and forth
1 participant