Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] More icons and some image squishing #191

Merged
merged 7 commits into from
Oct 10, 2021
Merged

[ADD] More icons and some image squishing #191

merged 7 commits into from
Oct 10, 2021

Conversation

markopolo123
Copy link
Contributor

I'm finding it therapeutic drawing icons :)
Also squished some more images with imgbot.

ImgBotApp and others added 3 commits October 5, 2021 21:16
*Total -- 1,479.38kb -> 1,350.08kb (8.74%)

/libraries/gabi-as-cosmos/periodic-table.png -- 65.12kb -> 51.78kb (20.5%)
/libraries/jasoncoelho/arduino-micro.png -- 100.44kb -> 84.77kb (15.61%)
/libraries/rohanp/system-design.png -- 219.54kb -> 185.44kb (15.53%)
/libraries/thebrahmnicboy/Logic-Gates.png -- 46.85kb -> 40.35kb (13.87%)
/libraries/corlaez/hexagonal-architecture.png -- 249.99kb -> 221.92kb (11.23%)
/libraries/markopolo123/dev_ops.png -- 244.80kb -> 220.98kb (9.73%)
/libraries/IvanReznikov/yellow-box.png -- 244.85kb -> 241.17kb (1.5%)
/libraries/jdelacruz/veeam_unofficial.png -- 307.78kb -> 303.68kb (1.33%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
Signed-off-by: Mark <mark.sharpley@astrazenenca.com>
Signed-off-by: Mark <mark.sharpley@astrazenenca.com>
@vercel
Copy link

vercel bot commented Oct 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-libraries/8VjjrwVxudqQwRMxXuASN7V2iT99
✅ Preview: https://excalidraw-libraries-git-fork-markopolo123-main-excalidraw.vercel.app

@markopolo123
Copy link
Contributor Author

markopolo123 commented Oct 5, 2021

LMK if you want me to revert the image squishing :)

Also, if you would be willing to add this repository to Hacktoberfest that would be awesome ;)

You can politely request the maintainer of the project you contributed to, to tag your contribution with the label **hacktoberfest-accepted** . Or, add the 'hacktoberfest' topic to the repository to opt the project into Hacktoberfest.


Any pull request with the **hacktoberfest-accepted** label, submitted to any public GitHub/GitLab repository, with or without the hacktoberfest topic, will be considered valid for Hacktoberfest.

Signed-off-by: Mark <mark.sharpley@astrazenenca.com>
@dwelle
Copy link
Member

dwelle commented Oct 8, 2021

Thanks for the updates!

Were these git branches items committed by mistake (we will soon make it easier to pick which libs you wanna export)? If deliberate, I'd consider putting them in a separate library as they doesn't feel to belong with the logos.

image

LMK if you want me to revert the image squishing :)

Are you up to take this one #193?

Also, if you would be willing to add this repository to Hacktoberfest that would be awesome ;)

Should be fine; will discuss.

Signed-off-by: Mark <mark.sharpley@astrazenenca.com>
libraries.json Outdated Show resolved Hide resolved
Signed-off-by: Mark Sharpley <698889+markopolo123@users.noreply.github.com>
@markopolo123
Copy link
Contributor Author

@dwelle I've removed the git bits for now, will rethink them.

libraries.json Outdated Show resolved Hide resolved
@dwelle
Copy link
Member

dwelle commented Oct 10, 2021

Beautiful work as always, thanks!

@dwelle dwelle merged commit 01d47ab into excalidraw:main Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants