feat: Remove copy & paste from context menu on desktop

[h7y]

Fixes #2868

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/ku8z1d92e
✅ Preview: https://excalidraw-git-fork-h7y-remove-copy-paste.excalidraw.vercel.app

[dwelle]

I think you should move the helper over to is-mobile.tsx, because utils.ts are used by packages which do use that sass loader which allows importing scss files.

I'd also factor out this part and reuse in both places:

excalidraw/src/is-mobile.tsx

Lines 13 to 19 in ed0bec4

	query.current = window.matchMedia
	? window.matchMedia(variables.isMobileQuery)
	: (({
	matches: false,
	addListener: () => {},
	removeListener: () => {},
	} as any) as MediaQueryList);

[h7y]

Just noticed this. I'm on it!

[h7y]

I think you should move the helper over to is-mobile.tsx, because utils.ts are used by packages which do use that sass loader which allows importing scss files.

I'd also factor out this part and reuse in both places:

excalidraw/src/is-mobile.tsx

Lines 13 to 19 in ed0bec4

	query.current = window.matchMedia
	? window.matchMedia(variables.isMobileQuery)
	: (({
	matches: false,
	addListener: () => {},
	removeListener: () => {},
	} as any) as MediaQueryList);

I've moved the helper to is-mobile.tsx. I'm having trouble understanding the factoring out part. Should I replicate the same logic in the helper?

[dwelle]

I meant something like factoring this part out:

window.matchMedia 
   ? window.matchMedia(variables.isMobileQuery) 
   : (({ 
       matches: false, 
       addListener: () => {}, 
       removeListener: () => {}, 
     } as any) as MediaQueryList);

into a helper called getIsMobileMatcher()

which you'd then call in both of those places where you need it.

[dwelle]

But we still can (should) export const isMobile => getIsMobileMatcher().matches instead.

[dwelle]

My suggestion above was incorrect, it should have been a function (well what I suggested wasn't even syntactically correct). Fixed.

[dwelle]

Made into feat coz it's quite radical change I think.

[h7y]

Perfect!

[dwelle]

Thanks! ❤️