Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlineStr cell type support #1575 #1576

Merged
merged 5 commits into from
Sep 7, 2021
Merged

Conversation

drdmitry
Copy link
Contributor

Summary

Implementing inlineStr cell type fixing issue #1575

Test plan

Tested stream reading of the xlsx file that has cells defined as <c ... t="inlineStr"><is><t>value here</t></is></c> - values gets populated, instead of null values before the fix.

@alubbe
Copy link
Member

alubbe commented Jan 5, 2021

Could you please add a new test with that test file to make sure we don't lose this functionality over time?

@drdmitry
Copy link
Contributor Author

drdmitry commented Jan 8, 2021

@alubbe, added integration test with the sample file.

@Siemienik Siemienik self-requested a review February 12, 2021 02:29
@drdmitry
Copy link
Contributor Author

drdmitry commented Aug 5, 2021

@Siemienik, could you please review and merge this PR?

@Siemienik
Copy link
Member

Yes, I will if only I found free time.

@alubbe alubbe merged commit 33d833f into exceljs:master Sep 7, 2021
@drdmitry drdmitry deleted the inline-str-support branch September 7, 2021 09:47
@sveisvei
Copy link

sveisvei commented Jan 5, 2022

When will this be released?

@gaurav-cointab
Copy link

when will this be release, because right now in "4.3.0" also this fix is not present. We are getting the inlineStr cell as "NULL", please make a small release for this issue, if possible... Currently we are using the npm release version. Do we have to pull from github directly and then use the fix, or will you be making a release in npm also ?

@adrian-morariu-modus-create

@Siemienik please release a new version with this fix

@Siemienik
Copy link
Member

@adrian-morariu-modus-create see #2351 ,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants