fix: fix type definitions about last column, formula values and protection #2309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several type definition has been fixed. Details:
Worksheet.lastColumn
can beundefined
for an empty worksheet, asWorksheet.lastRow
can beundefined
.date1904
should be an optional property for bothCellFormulaValue
andCellSharedFormulaValue
.CellFormulaValue.result
andCellSharedFormulaValue.result
should includeboolean
.CellFormulaValue.result
andCellSharedFormulaValue.result
should includeCellErrorValue
, not{ error: CellErrorValue }
, becauseCellErrorValue
itself is already an interface witherror
as its property.Protection
should have ahidden
property, as is recorded in the documentation.dashed
should be a valid value forBorderStyle
, as is documented in ISO/IEC 29500-1:2016 18.18.3 ST_BorderStyle (Border Line Styles).Test plan
Related to source code (for typings update)
exceljs/index.d.ts
Lines 1188 to 1191 in ec92cb3
exceljs/lib/xlsx/xform/sheet/cell-xform.js
Lines 95 to 99 in ec92cb3
exceljs/lib/xlsx/xform/sheet/cell-xform.js
Lines 354 to 355 in ec92cb3
exceljs/lib/xlsx/xform/sheet/cell-xform.js
Lines 356 to 357 in ec92cb3
exceljs/lib/xlsx/xform/style/protection-xform.js
Lines 42 to 45 in ec92cb3