Impl <xdr:twoCellAnchor editAs=oneCell> #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyonroche
requested changes
Oct 5, 2017
| @@ -30,7 +30,7 @@ utils.inherits(CellPositionXform, BaseXform, { | |||
| this.map['xdr:col'].render(xmlStream, col); | |||
| this.map['xdr:colOff'].render(xmlStream, colOff); | |||
|
|
|||
| var row = Math.floor(model.row); | |||
| var row = model.editAsOneCell ? 0 : Math.floor(model.row); | |||
There was a problem hiding this comment.
Shouldn't the same adjustment be done to col (above)?
Also - is there any adjustment required for the parse functions?
There was a problem hiding this comment.
I'll take a look at the parse function. About the col I don't know, I just looked into what OOo writes and did the same ;-)
There was a problem hiding this comment.
I've finally had some time to look into this. From what I can see (based on how Excel behaves) the row adjustment is not necessary, so I've removed it.
| @@ -49,7 +49,12 @@ utils.inherits(TwoCellAnchorXform, BaseXform, { | |||
| }, | |||
|
|
|||
| render: function(xmlStream, model) { | |||
| xmlStream.openNode(this.tag); | |||
| if(model.range.editAs) | |||
There was a problem hiding this comment.
I know it's pedantic but could you add braces to this if statement
|
At the moment I have no additional time to look for the parsing. I'm sorry. May be later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible at the moment to store a image with an offset to tl and br.