Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor PK settings #402

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Honor PK settings #402

merged 2 commits into from
Feb 14, 2024

Conversation

rromanchuk
Copy link
Contributor

Pull Request

Summary:
This was talked about in the README, but I missed it from the upgrading doc. I should know better since I make this mistake/forget every time I run a gem migrations.

I just copied ActiveStorage style https://github.com/rails/rails/pull/42378/files#diff-a99d3a53b13fcab0bb710064be91c98c5929b3ecc8a000d6b9af47ec74a4c6c4

For those that utilize

# application.rb
config.generators do |g|
  g.orm :active_record, primary_key_type: :uuid
end

@excid3 excid3 marked this pull request as ready for review February 14, 2024 17:24
@excid3
Copy link
Owner

excid3 commented Feb 14, 2024

This would be handy to have built-in (and for any gem with migrations).

@excid3 excid3 merged commit d7ed992 into excid3:main Feb 14, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants