Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined ApplicationDeliveryMethod #470

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

adrienpoly
Copy link
Contributor

Pull Request

Summary:

While trying to implement a custom delivery method with Noticed V2 we had to replace ApplicationDeliveryMethod by Noticed::DeliveryMethod

I could find any reference in the code to ApplicationDeliveryMethod so I think this should be the correct way of doing it

Checklist:

  • Code follows the project's coding standards
  • Tests have been added or updated to cover the changes
  • Documentation has been updated (if applicable)
  • All existing tests pass
  • Conforms to the contributing guidelines

@excid3
Copy link
Owner

excid3 commented Jul 15, 2024

@adrienpoly
Copy link
Contributor Author

ah ok thanks I didn't use the generator to create this custom delivery method.

Maybe then we could update the texte like that

- This will generate a new DeliveryMethods::Discord class inside the app/notifiers/delivery_methods folder, which can be used to deliver notifications to Discord.
+ This will generate a new ApplicationDeliveryMethod and DeliveryMethods::Discord class inside the app/notifiers/delivery_methods folder, which can be used to deliver notifications to Discord.

@excid3
Copy link
Owner

excid3 commented Jul 15, 2024

That's fine with me.

@adrienpoly
Copy link
Contributor Author

done

@excid3 excid3 merged commit 71ad318 into excid3:main Jul 15, 2024
@adrienpoly adrienpoly deleted the patch-1 branch July 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants