Fix transition options inconsistency/bug #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between leave() and enter() transitionOptions was inconsistent on how it handled the toggleClass/toggle option. Now excepting both options.
|
Great catch @jaywhy 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug or inconsistency in how
transitionOptionsare used in theenter()andleave()functions insidetransition.js.enter()expectstoggleClassleave()expectstoggle:This patch combines
transitionOptionparsing into one function,getTransitionOptions,to keep everything consistent. It also allows for bothtoggleandtoggleClassoptions to maintain backward compatibility.I've added tests to cover this issue.
As an added bonus, I noticed I was using a couple
await aTimeout(100)calls in my pull request earlier. They don't need to wait that long, so I changed them toawait aTimeout(0). This speeds up the tests by .3 seconds or so. 😃