⬆️ UPGRADE: myst-parser to 0.15.2 #353

mmcky · 2021-08-25T10:48:22Z

This PR upgrades myst-parser to version 0.15.2.

This includes the following improvements and changes

Tasks

Wait for myst-parser 0.15.2 release
Update dependency here
Merge!

chrisjsewell · 2021-08-25T10:52:59Z

Thanks @mmcky! but I think you are missing the crucial change of actually updating setup.cfg lol

chrisjsewell · 2021-08-25T10:53:38Z

ah yeh thats the one

mmcky · 2021-08-25T10:54:11Z

Thanks @mmcky! but I think you are missing the crucial change of actually updating setup.cfg lol

Yeah thanks -- I used git checkout . when working with the test set and it reset the change :-(. All fixed up.

codecov · 2021-08-25T10:55:30Z

Codecov Report

Merging #353 (be185b2) into master (b132a50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          12       12           
  Lines        1337     1337           
=======================================
  Hits         1169     1169           
  Misses        168      168

Flag	Coverage Δ
pytests	`87.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b132a50...be185b2. Read the comment docs.

mmcky · 2021-08-25T10:59:58Z

update readthedocs and fix this warning

WARNING: The config value `myst_url_schemes' has type `tuple', defaults to `list'.

choldgraf · 2021-08-25T17:16:53Z

ah excellent! @mmcky is this ready for review or do you wanna get tests passing first?

mmcky · 2021-08-26T01:53:14Z

thanks @choldgraf I think I just fixed the readthedocs issue. So I'll tag this for review once everything is green.

mmcky · 2021-08-26T01:55:44Z

Thanks @choldgraf and @chrisjsewell I think this is ready to 🚢

chrisjsewell · 2021-08-26T13:21:24Z

WARNING: The config value myst_url_schemes' has type tuple', defaults to `list'.

Hmm, maybe this should be "fixed" in myst-parser, as really there should be no problem with a tuple (you can specify a list of allowed types https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_config_value)

chrisjsewell · 2021-08-26T13:24:47Z

Thanks @choldgraf and @chrisjsewell I think this is ready to 🚢

Maybe just wait for me to release v0.15.2 and pin to that, since it is anyway needed for sphinx 4: #352 (comment). Will try to do in next day or 2

choldgraf · 2021-08-26T16:37:16Z

sounds good - I have added the next steps in this PR...we should get it merged quickly once 0.15.2 is out so that we can bump up the dependencies in jupyter book and resolve some of these pipfile issues 😬

mmcky · 2021-08-27T01:02:42Z

WARNING: The config value myst_url_schemes' has type tuple', defaults to `list'.

Hmm, maybe this should be "fixed" in myst-parser, as really there should be no problem with a tuple (you can specify a list of allowed types https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_config_value)

@chrisjsewell yeah I thought that might be true but it was actually specified in docs/conf.py of this repo so this is fixed now.

Ah I just re-read your comment -- I see. So a tuple should be OK.

setup.cfg

choldgraf

Note: I've bumped to 0.15.2.

The changes all look good to me - seem pretty straightforward. I had one question about person-specific paths in the regression files, but I don't think that needs to block this since those will be manually updated in future PRs anyway

choldgraf · 2021-08-27T18:21:57Z

tests/test_execute/test_complex_outputs_unrun_auto.ipynb

@@ -430,7 +430,7 @@
     "execution_count": 5,
     "metadata": {
      "filenames": {
-       "image/png": "/private/var/folders/t2/xbl15_3n4tsb1vr_ccmmtmbr0000gn/T/pytest-of-chrisjsewell/pytest-679/test_complex_outputs_unrun_aut0/source/_build/jupyter_execute/complex_outputs_unrun_22_0.png"
+       "image/png": "/private/var/folders/_w/bsp9j6414gs4gdlnhhcnqm9c0000gn/T/pytest-of-matthewmckay/pytest-37/test_complex_outputs_unrun_aut0/source/_build/jupyter_execute/complex_outputs_unrun_22_0.png"


is there any way we can configure tests to not be person-specific? otherwise I think this will be re-written any time somebody has to update the tests who didn't update them in the past.

@choldgraf I just updated a whole bunch of metadata in the tests in upgrade to sphinx 4 and the tests actually ignore the metadata

MyST-NB/tests/conftest.py

Line 23 in b132a50

set_notebook_diff_targets(metadata=False)

I don't see an easy way to generate these fixtures with generic values.

as mentioned, the actual tests ignore these values when diffing.
if you wanted to reduce the diff though, it would be possible to add a pre-commit hook, which replaces all the "non-deterministic" content with deterministic ones

mmcky · 2021-08-29T23:30:02Z

I think this is good to go -- do you agree @chrisjsewell?

Once this is merged I will start on sphinx >= 4 work and will rebase on this starting point.

docs/conf.py

chrisjsewell

cheers!

mmcky · 2021-08-29T23:36:01Z

thanks @chrisjsewell 👍 once all tests reporting green -- I'll merge.

UPGRADE: myst-parser==0.15.1

3582af2

mmcky mentioned this pull request Aug 25, 2021

MAIN: Enable support for Sphinx>=4 #352

Closed

4 tasks

fix previous revert for updating test fixtures

830769b

convert myst_url_schemes to be of type list

062d8ce

mmcky requested review from chrisjsewell and choldgraf August 26, 2021 01:55

choldgraf reviewed Aug 27, 2021

View reviewed changes

setup.cfg Outdated Show resolved Hide resolved

Update setup.cfg

94b8db5

choldgraf changed the title ~~⬆️ UPGRADE: myst-parser to 0.15.1~~ ⬆️ UPGRADE: myst-parser to 0.15.2 Aug 27, 2021

choldgraf previously approved these changes Aug 27, 2021

View reviewed changes

chrisjsewell reviewed Aug 29, 2021

View reviewed changes

docs/conf.py Outdated Show resolved Hide resolved

removing as now a default in myst_parser

be185b2

mmcky dismissed choldgraf’s stale review via be185b2 August 29, 2021 23:33

chrisjsewell approved these changes Aug 29, 2021

View reviewed changes

mmcky merged commit a3b2c6e into master Aug 29, 2021

mmcky deleted the myst-parser=0.15.1 branch August 29, 2021 23:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⬆️ UPGRADE: myst-parser to 0.15.2 #353

⬆️ UPGRADE: myst-parser to 0.15.2 #353

mmcky commented Aug 25, 2021 •

edited

Loading

chrisjsewell commented Aug 25, 2021

chrisjsewell commented Aug 25, 2021

mmcky commented Aug 25, 2021 •

edited

Loading

codecov bot commented Aug 25, 2021 •

edited

Loading

mmcky commented Aug 25, 2021 •

edited

Loading

choldgraf commented Aug 25, 2021

mmcky commented Aug 26, 2021

mmcky commented Aug 26, 2021

chrisjsewell commented Aug 26, 2021

chrisjsewell commented Aug 26, 2021

choldgraf commented Aug 26, 2021

mmcky commented Aug 27, 2021 •

edited

Loading

choldgraf left a comment •

edited

Loading

choldgraf Aug 27, 2021

mmcky Aug 29, 2021

chrisjsewell Aug 29, 2021

mmcky commented Aug 29, 2021

chrisjsewell left a comment

mmcky commented Aug 29, 2021

⬆️ UPGRADE: myst-parser to 0.15.2 #353

⬆️ UPGRADE: myst-parser to 0.15.2 #353

Conversation

mmcky commented Aug 25, 2021 • edited Loading

Tasks

chrisjsewell commented Aug 25, 2021

chrisjsewell commented Aug 25, 2021

mmcky commented Aug 25, 2021 • edited Loading

codecov bot commented Aug 25, 2021 • edited Loading

Codecov Report

mmcky commented Aug 25, 2021 • edited Loading

choldgraf commented Aug 25, 2021

mmcky commented Aug 26, 2021

mmcky commented Aug 26, 2021

chrisjsewell commented Aug 26, 2021

chrisjsewell commented Aug 26, 2021

choldgraf commented Aug 26, 2021

mmcky commented Aug 27, 2021 • edited Loading

choldgraf left a comment • edited Loading

Choose a reason for hiding this comment

choldgraf Aug 27, 2021

Choose a reason for hiding this comment

mmcky Aug 29, 2021

Choose a reason for hiding this comment

chrisjsewell Aug 29, 2021

Choose a reason for hiding this comment

mmcky commented Aug 29, 2021

chrisjsewell left a comment

Choose a reason for hiding this comment

mmcky commented Aug 29, 2021

mmcky commented Aug 25, 2021 •

edited

Loading

mmcky commented Aug 25, 2021 •

edited

Loading

codecov bot commented Aug 25, 2021 •

edited

Loading

mmcky commented Aug 25, 2021 •

edited

Loading

mmcky commented Aug 27, 2021 •

edited

Loading

choldgraf left a comment •

edited

Loading