-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ UPGRADE: myst-parser to 0.15.2 #353
Conversation
Thanks @mmcky! but I think you are missing the crucial change of actually updating |
ah yeh thats the one |
Yeah thanks -- I used |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 12 12
Lines 1337 1337
=======================================
Hits 1169 1169
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
ah excellent! @mmcky is this ready for review or do you wanna get tests passing first? |
thanks @choldgraf I think I just fixed the |
Thanks @choldgraf and @chrisjsewell I think this is ready to 🚢 |
Hmm, maybe this should be "fixed" in myst-parser, as really there should be no problem with a tuple (you can specify a list of allowed types https://www.sphinx-doc.org/en/master/extdev/appapi.html#sphinx.application.Sphinx.add_config_value) |
Maybe just wait for me to release v0.15.2 and pin to that, since it is anyway needed for sphinx 4: #352 (comment). Will try to do in next day or 2 |
sounds good - I have added the next steps in this PR...we should get it merged quickly once 0.15.2 is out so that we can bump up the dependencies in jupyter book and resolve some of these |
@chrisjsewell yeah I thought that might be true but it was actually specified in Ah I just re-read your comment -- I see. So a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I've bumped to 0.15.2.
The changes all look good to me - seem pretty straightforward. I had one question about person-specific paths in the regression files, but I don't think that needs to block this since those will be manually updated in future PRs anyway
@@ -430,7 +430,7 @@ | |||
"execution_count": 5, | |||
"metadata": { | |||
"filenames": { | |||
"image/png": "/private/var/folders/t2/xbl15_3n4tsb1vr_ccmmtmbr0000gn/T/pytest-of-chrisjsewell/pytest-679/test_complex_outputs_unrun_aut0/source/_build/jupyter_execute/complex_outputs_unrun_22_0.png" | |||
"image/png": "/private/var/folders/_w/bsp9j6414gs4gdlnhhcnqm9c0000gn/T/pytest-of-matthewmckay/pytest-37/test_complex_outputs_unrun_aut0/source/_build/jupyter_execute/complex_outputs_unrun_22_0.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way we can configure tests to not be person-specific? otherwise I think this will be re-written any time somebody has to update the tests who didn't update them in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@choldgraf I just updated a whole bunch of metadata in the tests in upgrade to sphinx 4
and the tests actually ignore the metadata
Line 23 in b132a50
set_notebook_diff_targets(metadata=False) |
I don't see an easy way to generate these fixtures with generic values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned, the actual tests ignore these values when diffing.
if you wanted to reduce the diff though, it would be possible to add a pre-commit hook, which replaces all the "non-deterministic" content with deterministic ones
I think this is good to go -- do you agree @chrisjsewell? Once this is merged I will start on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers!
thanks @chrisjsewell 👍 once all tests reporting green -- I'll merge. |
This PR upgrades
myst-parser
to version0.15.2
.This includes the following improvements and changes
Tasks