-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPGRADE: sphinx-togglebutton v0.3.0 #390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 12 12
Lines 1368 1368
=======================================
Hits 1195 1195
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Hmmm - the regression failures seem related to the myst-nb execution phase. If this is a non-trivial fix then maybe I'll just wait until #380 is in before bumping sphinx-togglebutton, or maybe @chrisjsewell can bump the version as a part of #380 ? EDIT: The test errors were due to a recent release of pandas ( |
I'll plan on merging this in a day or so, and cutting a 0.13.2 release, so that we can see these changes in the book theme and update more CSS if need be, unless I hear any objections before then (in particular I don't wanna mess up @chrisjsewell in #380 so lemme know if this would be disruptive) |
OK, I haven't got any objections so I'm merging this one in. Will cut a 0.13.2 release while I'm at it |
Yeh I think it's fine cheers |
This PR does 2 things:
sphinx-togglebutton
to ~= 0.3.0, so that we get the new UI elements that it introducedI know we have a big rewrite in the works but I don't think this will affect that since this is just a version bump + docs