Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPGRADE: sphinx-togglebutton v0.3.0 #390

Merged
merged 7 commits into from
Feb 10, 2022

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Feb 6, 2022

This PR does 2 things:

  • Raises the pin on sphinx-togglebutton to ~= 0.3.0, so that we get the new UI elements that it introduced
  • Removes some of the specific instructions in our "hide markdown content" section, because (I believe) we deprecated the ability to hide markdown cells with a cell tag, and so that content was out-of-date. This section now links out to the sphinx-togglebutton and sphinx-design docs, since myst-nb isn't directly responsible for hiding regular ol' content blocks.

I know we have a big rewrite in the works but I don't think this will affect that since this is just a version bump + docs

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #390 (5d6bc62) into master (5f4b8f6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          12       12           
  Lines        1368     1368           
=======================================
  Hits         1195     1195           
  Misses        173      173           
Flag Coverage Δ
pytests 87.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4b8f6...5d6bc62. Read the comment docs.

@choldgraf
Copy link
Member Author

choldgraf commented Feb 6, 2022

Hmmm - the regression failures seem related to the myst-nb execution phase. If this is a non-trivial fix then maybe I'll just wait until #380 is in before bumping sphinx-togglebutton, or maybe @chrisjsewell can bump the version as a part of #380 ?

EDIT: The test errors were due to a recent release of pandas (1.4) raising warnings that broke our regression tests, so I've pinned it in our test suite similar to what we're doing with matplotlib.

@choldgraf
Copy link
Member Author

choldgraf commented Feb 7, 2022

I'll plan on merging this in a day or so, and cutting a 0.13.2 release, so that we can see these changes in the book theme and update more CSS if need be, unless I hear any objections before then (in particular I don't wanna mess up @chrisjsewell in #380 so lemme know if this would be disruptive)

@choldgraf
Copy link
Member Author

OK, I haven't got any objections so I'm merging this one in. Will cut a 0.13.2 release while I'm at it

@choldgraf choldgraf merged commit 82212cf into executablebooks:master Feb 10, 2022
@choldgraf choldgraf deleted the upg-togglebutton branch February 10, 2022 19:45
@chrisjsewell
Copy link
Member

Yeh I think it's fine cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants