Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sphinx requirement from <6,>=4 to >=4,<7 #513

Closed
wants to merge 6 commits into from
Closed

Update sphinx requirement from <6,>=4 to >=4,<7 #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac5ea3f
Update sphinx requirement from <6,>=4 to >=4,<7
dependabot[bot] Apr 24, 2023
dd8b78a
Latest sphinx in tests
choldgraf Apr 24, 2023
699f039
Update python version
choldgraf Apr 24, 2023
7241149
Quotes YAML
choldgraf Apr 24, 2023
1f4793b
Update .github/workflows/tests.yml
choldgraf Apr 24, 2023
e03eee0
Update pyproject.toml
choldgraf Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: Set up Python 3.8
- name: Set up Python 3.10
uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: "3.10"
- uses: pre-commit/action@v3.0.0

tests:
Expand All @@ -26,18 +26,19 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.7", "3.8", "3.9", "3.10"]
sphinx: [">=5,<6"]
python-version: ["3.8", "3.9", "3.10"]
sphinx: [">=6,<7"]
include:
# One test for an earlier Sphinx version
- os: ubuntu-latest
python-version: 3.7
sphinx: ">=4,<5"
- os: windows-latest
python-version: 3.8
python-version: "3.10"
sphinx: ">=5,<6"
- os: windows-latest
python-version: "3.10"
sphinx: ">=6,<7"
- os: macos-latest
python-version: 3.8
sphinx: ">=5,<6"
python-version: "3.10"
sphinx: ">=6,<7"

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -82,7 +83,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: "3.10"
- name: install flit
run: |
pip install flit~=3.4
Expand Down
5 changes: 2 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand All @@ -33,7 +32,7 @@ keywords = [
"docutils",
"sphinx",
]
requires-python = ">=3.7"
requires-python = ">=3.8"
dependencies = [
"importlib_metadata",
"ipython",
Expand All @@ -42,7 +41,7 @@ dependencies = [
"myst-parser~=0.18.0",
"nbformat~=5.0",
"pyyaml",
"sphinx>=4,<6",
"sphinx>=4,<7",
"typing-extensions",
# ipykernel is not a requirement of the library,
# but is a common requirement for users (registers the python3 kernel)
Expand Down