Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glueing docs for NumPy >=2.0 #615

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

bryanwweber
Copy link
Contributor

@bryanwweber bryanwweber commented Jul 8, 2024

As discussed in #610, changes in NumPy 2.0 for text/plain representation of numbers means that we need an adjustment to either NumPy's print options or how glueing is done. This docs update should address those changes while potential adjustments are sorted out upstream.

Closes #610

Screenshot on a locally built page

image

Changes to the text/plain representation of NumPy objects for NumPy >= 2.0 mean that we need a workaround for formatting.
@bryanwweber
Copy link
Contributor Author

@agoose77 I hope this change helps clarify #610 and how to work around it. Do you mind reviewing? Thank you 🙏

@bsipocz bsipocz added the documentation Improvements or additions to documentation label Sep 19, 2024
Copy link
Collaborator

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added warning block looks good to me, thank you @bryanwweber!

@bsipocz bsipocz merged commit db8cedb into executablebooks:master Sep 19, 2024
13 checks passed
@bryanwweber bryanwweber deleted the update-docs-gh-610 branch September 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With NumPy 2.0, text/plain + float formatting results in SphinxWarning
2 participants