Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: mention $$ instead of $ #379

Closed
wants to merge 1 commit into from
Closed

Conversation

mgeier
Copy link

@mgeier mgeier commented May 10, 2021

The current text suggests that MathJax recognizes single $ by default, which is not true.

@welcome
Copy link

welcome bot commented May 10, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

Thnaks yeh I actually just remembered this whilst writing #378 lol

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #379 (cff92f4) into master (a39d236) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   90.54%   90.54%           
=======================================
  Files          14       14           
  Lines        1830     1830           
=======================================
  Hits         1657     1657           
  Misses        173      173           
Flag Coverage Δ
pytests 90.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39d236...cff92f4. Read the comment docs.

@chrisjsewell
Copy link
Member

As of #390, we now use the method of setting a top-level mathjax_ignore in myst documents and setting the MathJax config "processClass": "tex2jax_process|mathjax_process|math".
Therefore, this is no longer relevant.

@mgeier mgeier deleted the patch-1 branch June 13, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants