Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Un-wrap announcement in <p> #732

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

choldgraf
Copy link
Member

The announcement text at the top was having a base pydata theme color applied to it because it was wrapped in <p>, the simplest fix is just to un-wrap it for now, though this should probably be made more robust in the pydata theme as well.

The announcement text at the top was having a base pydata theme color applied to it because it was wrapped in `<p>`, the simplest fix is just to un-wrap it for now, though this should probably be made more robust in the pydata theme as well.
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8bf2522) 89.95% compared to head (e3c373e) 89.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          23       23           
  Lines        2967     2967           
=======================================
  Hits         2669     2669           
  Misses        298      298           
Flag Coverage Δ
pytests 89.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell
Copy link
Member

Ah ok cheers, I thought it looked a little off
I used the <p> because it was in the documentation: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/announcements.html#provide-local-html-in-your-theme, so yeh might wanna look into that

@chrisjsewell chrisjsewell changed the title DOCS: Un-wrap announcement in <p> 📚 DOCS: Un-wrap announcement in <p> Mar 1, 2023
@chrisjsewell chrisjsewell merged commit 585ce9a into master Mar 1, 2023
@chrisjsewell chrisjsewell deleted the choldgraf-patch-1 branch March 1, 2023 15:15
@choldgraf
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants