Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pathlib #864

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

danieleades
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (e74769c) to head (cb24054).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #864   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files          24       24           
  Lines        3372     3372           
=======================================
  Hits         3037     3037           
  Misses        335      335           
Flag Coverage Δ
pytests 90.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell
Copy link
Member

heya @danieleades do you wanna fix the last few lints?:

myst_parser/inventory.py:410:10: PTH123 `open()` should be replaced by `Path.open()`
myst_parser/inventory.py:471:14: PTH123 `open()` should be replaced by `Path.open()`
myst_parser/mdit_to_docutils/base.py:1211:17: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator
myst_parser/mdit_to_docutils/sphinx_.py:68:17: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants