🔧 MAINTAIN: Create module exports for internal classes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsewell
reviewed
Aug 4, 2021
chrisjsewell
reviewed
Aug 4, 2021
|
|
This was the error that prompted me to add that option:
Seems like a solid thing to turn on in most cases. We are kicking #17 to another PR and this can come in now! |
chrisjsewell
requested changes
Nov 12, 2021
Allows creation of Directives and Roles externally.
chrisjsewell
changed the title
|
Woot! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creation of Directives and Roles externally.
This pushes the exports down into the various folders and exposes some of the classes to external packages. This is needed for other packages to create new roles/directives without knowing the internal structure of the library.