👌 IMPROVE: Type annotate common/utils
#160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 60 60
Lines 3232 3232
=======================================
Hits 3106 3106
Misses 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
|
|
||
| def charCodeAt(src: str, pos: int): | ||
| def charCodeAt(src: str, pos: int) -> Any: |
There was a problem hiding this comment.
The Any return type is to explicitly keep disabling type checking for the return value. This because the None case is pretty painful and dynamic: it happens when pos >= len(src) but in code, before calling the function, we always have dynamic checks to ensure this doesn't happen. Thus the proper Optional[int] annotation requires many ugly cast(int, ...)s.
Best would be to raise IndexError instead of returning None, but I guess that isn't true to JS upstream, so IMO this is the second best option.
There was a problem hiding this comment.
yeh I'm not picking at that thread right now 😬
3 participants
No description provided.