-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 FIX: Crash when file ends with empty blockquote line #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 61 61
Lines 3259 3263 +4
=======================================
+ Hits 3134 3138 +4
Misses 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thanks @hukkin. markdown-it-py/markdown_it/ruler.py Line 50 in 465b54d
so that it sets a "defaulttuple" that returns |
PS, ignore the docs error; that's a circular dependency issue that will be fixed when I release a new myst-nb |
Yeah I'd like that as well. I would suggest
Yep, thanks for the heads up. |
sounds good to me 👍 |
The only issue I see with the defaulttuple approach is that if Something to think about / measure perf perhaps |
Could you not just create a simple https://docs.python.org/3/library/collections.abc.html#collections.abc.Sequence class, that has |
Hmm perhaps but I wonder if you lose all C level optimization of the tuple datatype. Should probably just measure performance and see what's relevant and what's not. |
Sure ting 👍 |
Closes #185