Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Don't use different font size for sidebar content #144

Closed
pradyunsg opened this issue Aug 6, 2020 · 6 comments
Closed

Design: Don't use different font size for sidebar content #144

pradyunsg opened this issue Aug 6, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@pradyunsg
Copy link
Member

Is your feature request related to a problem? Please describe.

Font sizing changes in the sidebars make it difficult to read/skim the sidebar's contents and well as make it look out-of-place.

Describe the solution you'd like

Use the same size as the content for all navigation items in both sidebars.

  • The indentation is sufficient to make the "depth" clear.
  • Whitespace + bold text can be used for captions and toctrees to separate them visually.

See readme.com's design for inspiration/idea.

Describe alternatives you've considered

I can't think of any good ones. :)

Additional context

I'm happy to try implementing this myself, if there's interest in this idea. :)

@pradyunsg pradyunsg added the enhancement New feature or request label Aug 6, 2020
@welcome
Copy link

welcome bot commented Aug 6, 2020

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@pradyunsg pradyunsg changed the title Don't use different font size for sidebar content Design: Don't use different font size for sidebar content Aug 6, 2020
@pradyunsg
Copy link
Member Author

FWIW, I did manage to draft a few changes toward this. Here are two screenshots (side-by-side) of the before and after.

Screenshot 2020-08-06 at 6 25 02 PMScreenshot 2020-08-06 at 6 34 12 PM

And here's the two full-page demos:

(after)

Screenshot 2020-08-06 at 6 40 34 PM

(before)

Screenshot 2020-08-06 at 6 40 52 PM

@chrisjsewell
Copy link
Member

Well you have been busy @pradyunsg 😆
Looks great to me!

@choldgraf
Copy link
Member

+1 from me, I think that's reasonable and will help with accessibility efforts

@choldgraf
Copy link
Member

oh wait, I see you've already opened up a PR for this which I missed because I have like 50 github notifications from you ;-)

@chrisjsewell
Copy link
Member

I think this is now closed in #156, but feel free to re-open if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants