Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Use consistent font size in toc #157

Merged

Conversation

pradyunsg
Copy link
Member

Toward #144

@choldgraf
Copy link
Member

The main reason that this was a bit smaller was:

  1. To make it more distinguishable from the main content
  2. To avoid it getting cramped in the (relatively small) amount of space available to it

I'm open to bumping up the font size but curious what you think about those two concerns

@pradyunsg
Copy link
Member Author

Re 1: The positioning (indentation relative to content around + place on page) do a good enough job of distinguishing it IMO.

Re 2: This is definitely a valid concern.

There's a bunch of indirect-effects to balance (nudges for title length / less deeper headings, legibility of content etc) but I think it comes down to a choice of tradeoffs. The question I'd asked myself was: which is better, having h4 be more difficult to read (because of small font size) or need wrapping when it's moderately long? My answer was the latter.

TBH, what motivated this entire exercise was that I couldn't read the h4 easily without moving closer to the screen and wanted to try fixing it because it seemed easy enough. :)

@choldgraf
Copy link
Member

what motivated this entire exercise was that I couldn't read the h4 easily without moving closer to the screen

I think if you are having this experience then others are as well, so we should merge this

@choldgraf choldgraf changed the title Use consistent font size in toc 👌 IMPROVE: Use consistent font size in toc Aug 6, 2020
@choldgraf choldgraf merged commit 1af01d6 into executablebooks:master Aug 6, 2020
@choldgraf
Copy link
Member

thanks for the improvement! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants